From 0dbb77b023bdf735536ba1dac172aaf3000baedb Mon Sep 17 00:00:00 2001
From: Hermes Agent service account
 <hermes@carousel-of-progress.local.mk-labs.cloud>
Date: Thu, 13 Aug 2026 23:48:59 -0500
Subject: [PATCH] Fix OpenViking: 1Password item mismatch + invalid embedding
 config fields

Bug 1: ExternalSecret referenced three separate 1Password items
(openviking-root-api-key, openviking-embedding-api-key, openviking-vlm-api-key)
but Ryan created ONE item 'openviking' with three fields inside.
Changed all remoteRef.key values to 'openviking' and corrected field property names.

Bug 2: values.yaml had two invalid embedding config fields:
- encoding_format: 'float' (not in upstream schema, removed)
- max_concurrent under embedding.dense (wrong nesting, moved to embedding level)

Verified against upstream chart schema at github.com/volcengine/openviking
---
 cluster/platform/openviking/externalsecret.yaml | 16 ++++++++--------
 cluster/platform/openviking/values.yaml         |  2 --
 2 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/cluster/platform/openviking/externalsecret.yaml b/cluster/platform/openviking/externalsecret.yaml
index 5afd2ea..5a93108 100644
--- a/cluster/platform/openviking/externalsecret.yaml
+++ b/cluster/platform/openviking/externalsecret.yaml
@@ -34,24 +34,24 @@ spec:
 
   data:
     # OpenViking root API key - server administration
-    # Source: 1Password item "openviking-root-api-key", field "root-api-key"
+    # Source: 1Password item "openviking", field "root-api-key"
     - secretKey: OPENVIKING_ROOT_API_KEY
       remoteRef:
-        key: openviking-root-api-key
+        key: openviking
         property: root-api-key
 
     # Embedding model endpoint token (nomic-embed-text-v1.5 at astro-orbiter:8002)
-    # Source: 1Password item "openviking-embedding-api-key", field "api-key"
+    # Source: 1Password item "openviking", field "embedding-api-key"
     # Phase 0 recommendation: placeholder token for local endpoint
     - secretKey: OPENVIKING_EMBEDDING_API_KEY
       remoteRef:
-        key: openviking-embedding-api-key
-        property: api-key
+        key: openviking
+        property: embedding-api-key
 
     # VLM endpoint token (Llama-3.1-8B at astro-orbiter:8002)
-    # Source: 1Password item "openviking-vlm-api-key", field "api-key"
+    # Source: 1Password item "openviking", field "vlm-api-key"
     # Phase 0 recommendation: placeholder token for local endpoint
     - secretKey: OPENVIKING_VLM_API_KEY
       remoteRef:
-        key: openviking-vlm-api-key
-        property: api-key
+        key: openviking
+        property: vlm-api-key
diff --git a/cluster/platform/openviking/values.yaml b/cluster/platform/openviking/values.yaml
index bbf7578..89055ee 100644
--- a/cluster/platform/openviking/values.yaml
+++ b/cluster/platform/openviking/values.yaml
@@ -144,9 +144,7 @@ config:
       api_key: "${OPENVIKING_EMBEDDING_API_KEY}"  # Placeholder: "local-nomic" or similar
       model: "nomic-embed-text-v1.5"
       dimension: 768
-      encoding_format: "float"  # Required: avoid base64 encoding issues with OpenAI-compatible gateways
       input: "text"
-      max_concurrent: 5
     max_concurrent: 5
 
   # ============================================================================